Add Built Visual to PR action artifacts #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add artifact upload step to build workflow on PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the built visual as an artifact to the PR job to allow easy validation/checking/testing of PRs without having to spin anything else up.
Could also add it to the general workflow runs or a workflow_dispatch trigger to allow on-demand generation if required, but given the merge strategy you're using this should probably do it.
Artifacts expire after 90 days by default.
The artifact zip will have the github SHA as part of the filename, however the visual itself will remain versioned as normal.
You can see the completed action with artifact here.